Add test for #55913 #56096
Open
Add test for #55913 #56096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56096 +/- ##
=======================================
Coverage 87.99% 87.99%
=======================================
Files 656 656
Lines 189000 189000
Branches 35992 35991 -1
=======================================
+ Hits 166308 166318 +10
+ Misses 15851 15843 -8
+ Partials 6841 6839 -2 |
|
Can you fix the linter issue and move this to |
Fixed the linter issues. @aduh95 I plan to fix the issue once I can confirm that the test is failing. Should I still move the issue to If yes, what is the recommended way to deal with the test scaffolding from test-watch-mode.mjs - should I copy it over or write a test from scratch that does not use the existing test scaffolding (either seems cumbersome)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for #55913 that is expected to fail until issue is fixed. Please approve MacOS testing CI to verify test is failing as expected.